-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: close go-routines after session request has been answered #4122
Conversation
…m:inovex/scrumlr.io into mi/close-goroutines-after-session-request
🐙 OctomindTest Report: 0/14 successful.
commit sha: 8e8925b |
The deployment to the dev cluster was successful. You can find the deployment here: https://4122.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 0/14 successful.
commit sha: 872c602 |
Description
If the access policy for the board is “manual approval”, each user opens a request and thus a go routine.
Since there is a for loop within the routine that never returns, this routine runs forever.
To fix this, simply remove the for loop and use a select statement instead.
Changelog
api/board_session_requests_listen_on_request.go
Checklist
(Optional) Visual Changes